From 82eb3225d83b6865c4fd7dde8db4eeda3c411e3e Mon Sep 17 00:00:00 2001 From: Alexander Mendes Date: Tue, 17 Jul 2018 16:28:37 +0100 Subject: [PATCH 1/8] Remove duplicate active attribute --- pages/collection/_short_name/data.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/collection/_short_name/data.vue b/pages/collection/_short_name/data.vue index b07e6a31..dc00abab 100644 --- a/pages/collection/_short_name/data.vue +++ b/pages/collection/_short_name/data.vue @@ -64,7 +64,7 @@ - + Date: Thu, 19 Jul 2018 15:27:41 +0100 Subject: [PATCH 2/8] Make tags modal text configurable (close #830) --- .../collection/_short_name/presenter.vue | 13 ++++++ .../_short_name/projects/_id/_presenter.vue | 44 +++++-------------- utils/setCollectionDefaults.js | 4 +- 3 files changed, 26 insertions(+), 35 deletions(-) diff --git a/pages/admin/collection/_short_name/presenter.vue b/pages/admin/collection/_short_name/presenter.vue index ba61b2be..5e4901a5 100644 --- a/pages/admin/collection/_short_name/presenter.vue +++ b/pages/admin/collection/_short_name/presenter.vue @@ -40,6 +40,19 @@ The text to be used for the reject modal, above the options input. +
+ + + +
+ The text to be used for the tags modal. +
+
diff --git a/pages/collection/_short_name/projects/_id/_presenter.vue b/pages/collection/_short_name/projects/_id/_presenter.vue index 2048e216..e91e9bfa 100644 --- a/pages/collection/_short_name/projects/_id/_presenter.vue +++ b/pages/collection/_short_name/projects/_id/_presenter.vue @@ -151,40 +151,9 @@ -

- The tags added below will help researchers locate items of - particular interest by being used to generate keywords that can - be searched via the - - Browse - page. -

-

- For programmatic research purposes the data will also be available - via the API at - - {{ currentCollection.info.annotations.tags }} - -

-

- Tags can be added by anyone but, once confirmed, can only be deleted - by administrators. If you have spotted a tag that you think is - incorrect or should be removed for any reason please contact - - {{ localConfig.email }}. - -

-

- By default, a new tag will be added for each word. To create tags - that comprise multiple words please follow the convention of adding - a hyphen between words (e.g. my-long-tag). -

+ + +

Current tags:
Date: Thu, 19 Jul 2018 15:43:22 +0100 Subject: [PATCH 3/8] Remove finally blocks (close #831) --- pages/collection/_short_name/index.vue | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/pages/collection/_short_name/index.vue b/pages/collection/_short_name/index.vue index a09315f8..c0451891 100644 --- a/pages/collection/_short_name/index.vue +++ b/pages/collection/_short_name/index.vue @@ -392,6 +392,7 @@ export default { this.forumDiscussions = response.data.filter(discussion => { return !discussion.attributes.isSticky }).slice(0, 5) + this.loadingForumDiscussions = false }).catch(err => { // This is most likely a CORS issue with the forum endpoint if (process.env.NODE_ENV !== 'development') { @@ -400,11 +401,8 @@ export default { message: `Error loading latest forum discussions: ${err.message}` }) } - return { - forumDiscussions: [] - } - }).finally(() => { this.loadingForumDiscussions = false + this.forumDiscussions = [] }) }, @@ -421,19 +419,19 @@ export default { item.updated = new Date(item.updated * 1000) return item }).filter(item => { + this.loadingActivityFeed = false return ( item.action_updated === 'UserContribution' && item.category_id === this.collection.id ) }).slice(0, 5) }).catch(err => { + this.loadingActivityFeed = false this.$notifications.flash({ status: 'error', message: 'Failed to load recent activity' }) console.error(err) - }).finally(() => { - this.loadingActivityFeed = false }) }, From 5f49b88e952dfc595be29d0dd07f3892c597e2a5 Mon Sep 17 00:00:00 2001 From: Alexander Mendes Date: Thu, 19 Jul 2018 19:01:15 +0100 Subject: [PATCH 4/8] Add list of tags to browse page (close #832) --- components/cards/Base.vue | 6 +- components/data/SearchTags.vue | 11 ++ pages/collection/_short_name/browse.vue | 130 +++++++++++++++++------- 3 files changed, 111 insertions(+), 36 deletions(-) diff --git a/components/cards/Base.vue b/components/cards/Base.vue index c2cf9208..68869b08 100644 --- a/components/cards/Base.vue +++ b/components/cards/Base.vue @@ -5,7 +5,7 @@ :bg-variant="darkMode ? 'dark' : null" :text-variant="darkMode ? 'white' : null"> -