Update SendExtDesktopSize to include expected screen data in resize message #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few data points to the screen data structure that is used to send the desktop resize request to the server. In using this library with the Guacamole project, I encountered some issues getting the resize to work correctly when pointed at a TigerVNC server. A post to that mailing list and some digging in the code led to the conclusion that, while TigerVNC is expecting the screen ID, offset, and flags to contain valid data, libvncclient currently only sends the width and height, and the remaining data in the screen data structure is uninitialized.
This change copies the screen id, x and y offset, and flags, from the values in
client->screen, which, at least for a TigerVNC server, appears to work as expected, allowing the resize to take place.