Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#237 alt text update ep2 #309

Merged
merged 2 commits into from
Sep 1, 2023
Merged

#237 alt text update ep2 #309

merged 2 commits into from
Sep 1, 2023

Conversation

jas58
Copy link
Contributor

@jas58 jas58 commented Aug 12, 2023

testing if I understand #237

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

testing if I understand #237
@github-actions
Copy link

github-actions bot commented Aug 12, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-309

The following changes were observed in the rendered markdown documents:

 02-importing-data.md | 2 +-
 md5sum.txt           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-01 14:04:48 +0000

github-actions bot pushed a commit that referenced this pull request Aug 12, 2023
@ostephens
Copy link
Contributor

@jas58 this looks good to me but also see comments from @bencomp in #237 - I think it would be good to make those changes before this is merged

enriched alt-text for line 71 to become:
OpenRefine Create Project screen, with highlights for the address bar, mentioned settings and the Create Project button.
per comments in 237 and 309
@jas58 jas58 requested a review from ostephens September 1, 2023 14:03
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
@ostephens ostephens merged commit 5444fdc into main Sep 1, 2023
3 checks passed
@ostephens ostephens deleted the jas58-patch-1 branch September 1, 2023 14:19
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
Auto-generated via {sandpaper}
Source  : a212702
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-01 14:20:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5444fdc
Branch  : main
Author  : Owen Stephens <owen@ostephens.com>
Time    : 2023-09-01 14:19:44 +0000
Message : Merge pull request #309 from LibraryCarpentry/jas58-patch-1

#237 alt text update ep2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants