Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference correct DataFrame in to_pickle #146

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

vinegar-tom
Copy link
Contributor

The DataFrame without the changes made to it was passed to_pickle, causing the user to save the wrong data in the file.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
The DataFrame without the changes made to it was passed to_pickle, causing the user to save the wrong data in the file. When I did this and then read the pickle in the next episode, I had loaded the wrong data.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

The DataFrame without the changes made to it was passed `to_pickle`, causing the user to save the wrong data in the file.
Copy link

github-actions bot commented Oct 31, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-python-intro/compare/md-outputs..md-outputs-PR-146

The following changes were observed in the rendered markdown documents:

 data-visualisation.md | 4 ----
 md5sum.txt            | 4 ++--
 tidy.md               | 2 +-
 3 files changed, 3 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-05 16:53:26 +0000

@chennesy chennesy self-requested a review November 5, 2024 16:52
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Copy link
Contributor

@chennesy chennesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinegar-tom Nice catch! thanks.

@chennesy chennesy merged commit 14ba490 into LibraryCarpentry:main Nov 5, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : 14ba490
Branch  : main
Author  : Cody Hennesy <codyhennesy@gmail.com>
Time    : 2024-11-05 17:03:43 +0000
Message : Merge pull request #146 from vinegar-tom/patch-3

Reference correct DataFrame in `to_pickle`
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
Auto-generated via `{sandpaper}`
Source  : fd1c033
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-11-05 17:04:26 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 14ba490
Branch  : main
Author  : Cody Hennesy <codyhennesy@gmail.com>
Time    : 2024-11-05 17:03:43 +0000
Message : Merge pull request #146 from vinegar-tom/patch-3

Reference correct DataFrame in `to_pickle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants