Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown crash #245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Shutdown crash #245

wants to merge 6 commits into from

Conversation

ysard
Copy link

@ysard ysard commented Nov 4, 2021

Hi,
I propose 2 fixes on this PR.

  • First and basically a workaround regarding a regular Kodi crash due to the Dbus Connection Object that does not seem to be deleted correctly.

This has been exposed in this issue (LibreELEC/LibreELEC.tv#5645) but there, no action has been taken so far.

The bbc7bf3 commit of the PR #240 has not solved the problem on my side.

  • Secondly, by cleanliness a fix of anecdotal typo.

Thank you for reading

service.py Outdated Show resolved Hide resolved
@ysard
Copy link
Author

ysard commented Nov 6, 2021

I added some minor cleaning of code; now it's finished for me.

@chewitt
Copy link
Member

chewitt commented Nov 7, 2021

Looks like the dbussy author replied to the other thread and made changes already.

@ysard
Copy link
Author

ysard commented Nov 9, 2021

I read it, the del is still needed but not the collection anymore. Still investigating...

@ysard
Copy link
Author

ysard commented Nov 11, 2021

I think that the problem is closed on the dbussy side.
I added current debugging logs on the issue LibreELEC/LibreELEC.tv#5645.

I can remove the call to garbage collector since it is not used anymore. I can also clean the commit history (via push force) of this issue if you prefer.
Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

@CvH
Copy link
Member

CvH commented Dec 5, 2021

Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

we bumped dbussy (LibreELEC/LibreELEC.tv#5945) so it should work now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants