Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements at response from API when generate root certificate #1967

Open
vitormattos opened this issue Nov 23, 2023 · 0 comments
Open

Improvements at response from API when generate root certificate #1967

vitormattos opened this issue Nov 23, 2023 · 0 comments
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code php Pull requests that update Php code technical debt
Milestone

Comments

@vitormattos
Copy link
Member

Scenario

When we don't fill the field "Name (CN)" and click at the button "Generate root certificate" we will see the message:
Screenshot_20231123_144626

We need to see the message:

Name (CN) is required

Tips

Search by 'Name (CN)' in the code and search by 'parameter '{$key}' is required'. You will see that the array with the translated name stay at frontend and the text in backend. You also will found parameters here: apps-extra/libresign/src/helpers/certification.js

To-do

Will be necessary move the parameters names to backend because the validation occur at API side. To do this you will need to move the file apps-extra/libresign/src/helpers/certification.js to be a helper in API side and return this as JSON in an initial state to frontend.

@vitormattos vitormattos added good first issue Good for newcomers php Pull requests that update Php code javascript Pull requests that update Javascript code technical debt labels Nov 23, 2023
@vitormattos vitormattos added this to the Backlog milestone Nov 23, 2023
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers javascript Pull requests that update Javascript code php Pull requests that update Php code technical debt
Projects
Status: 0. Needs triage
Development

No branches or pull requests

1 participant