Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature metadata not visible when validating a signature #2616

Open
DazeEnd opened this issue Mar 28, 2024 · 5 comments
Open

Signature metadata not visible when validating a signature #2616

DazeEnd opened this issue Mar 28, 2024 · 5 comments
Labels
feature-request New feature request

Comments

@DazeEnd
Copy link

DazeEnd commented Mar 28, 2024

Describe the bug
When the "Collect signers' metadata when signing a document" options is turned ON, the signature metadata is not displayed when validating a signature.

To Reproduce

  1. As admin, go to Settings > LibreSign > Collect signers' metadata, and turn ON the "Collect signers' metadata when signing a document" setting.
  2. Request a signature on a document of your choice.
  3. Sign the document from Step 2.
  4. As admin, open the LibreSign app, click on "Files" in the left sidebar, and then click on the signed document to open the right sidebar.
  5. In the right sidebar, click the "Validate" button.

Expected behavior
Metadata for the signer should be displayed, including the browser user agent and the signer's IP address.

Actual behavior
The signer's metadata is not displayed anywhere I can find. It does not appear in the validate screen, or in the validation information that is added to the footer of the document.

Screenshots
LibreSign Settings:
image
Validation Screen:
image
Footer Validation Information:
image
Metadata Saved in Database:
image

Environment information (please complete the following information):

  • Server OS: AlmaLinux v8.9
  • Browser: Firefox
  • LibreSign Version: v8.0.0-rc9
  • Nextcloud Server Version: v28.0.2
  • Logs: There were no messages printed by LibreSign found in nextcloud.log

Additional context
The signer's metadata is being saved in the database. That metadata just isn't being displayed.

@DazeEnd DazeEnd added the bug Something isn't working label Mar 28, 2024
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Mar 28, 2024
@vitormattos
Copy link
Member

Changing from bug to feature.

@vitormattos vitormattos added feature-request New feature request and removed bug Something isn't working labels Mar 28, 2024
@vitormattos
Copy link
Member

vitormattos commented Mar 28, 2024

For now is possible to use the app Analytics and create a report to return this data.

I wish to refactor the validation screen to provide these data.

Also have more data that is not visible for now at table sign_request related to notifications.

@vitormattos
Copy link
Member

vitormattos commented Mar 28, 2024

@DazeEnd
Copy link
Author

DazeEnd commented Mar 28, 2024

@vitormattos wrote:

Is this issue duplicated of #2617 ?

No, it is not. They are separate, but related issues.

This issue is reporting that signer metadata (browser user agent and IP address) do not seem to be visible anywhere in the UI, even when that data is collected. At the very least, I would expect this metadata to be visible when validating a signature through the LibreSign UI.

Issue #2617 is requesting a new feature -- a "signature information page". Even if you implemented issue #2617, I think this issue (#2616) would still need attention so that metadata could be added to the signature validation URL.

If I didn't explain the distinction well, please let me know and I can try to clarify again.

@vitormattos
Copy link
Member

You are right.

This issue is more than to have a way to retrieve metadata, not what's the way, right?!

@vitormattos vitormattos added this to the Backlog milestone Apr 24, 2024
@vitormattos vitormattos modified the milestones: Backlog, Next Major (30) Jun 10, 2024
@vitormattos vitormattos moved this from 0. Needs triage to Next release in Roadmap Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
Status: Next release
Development

No branches or pull requests

2 participants