feature: medicare flow with pverify #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
| } | ||
|
|
||
| public function execute(EligibilityCheckDto $eligibilityCheckDto, array $mbiLookupResponse): array |
There was a problem hiding this comment.
mbiLookupResponse could just be the mbi string and not the whole response array, but if we wanted to keep the whole response we could create a dto, an array is a middle ground
| public function __construct( | ||
| public string $first_name, | ||
| public string $last_name, | ||
| public Carbon $dob, |
There was a problem hiding this comment.
we should use the iluminate version of carbon
| public USState $state, | ||
| public string $zip, | ||
| public string $plan_type, | ||
| public string $diabetes_type, |
rainierlightit
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.