Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lighbits cinder driver support #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding lighbits cinder driver support #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ansible/group_vars/all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ enable_cinder_backend_quobyte: "no"
enable_cinder_backend_pure_iscsi: "no"
enable_cinder_backend_pure_fc: "no"
enable_cinder_backend_pure_roce: "no"
enable_cinder_backend_lightbits: "no"
enable_cloudkitty: "no"
enable_collectd: "no"
enable_cyborg: "no"
Expand Down
3 changes: 3 additions & 0 deletions ansible/roles/cinder/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ cinder_backends:
enabled: "{{ enable_cinder_backend_pure_fc | bool }}"
- name: "{{ cinder_backend_pure_roce_name }}"
enabled: "{{ enable_cinder_backend_pure_roce | bool }}"
- name: "{{ cinder_backend_lightbits_name }}"
enabled: "{{ cinder_backend_lightbits | bool }}"

cinder_backend_ceph_name: "rbd-1"
cinder_backend_lvm_name: "lvm-1"
Expand All @@ -264,6 +266,7 @@ cinder_backend_quobyte_name: "QuobyteHD"
cinder_backend_pure_iscsi_name: "Pure-FlashArray-iscsi"
cinder_backend_pure_fc_name: "Pure-FlashArray-fc"
cinder_backend_pure_roce_name: "Pure-FlashArray-roce"
cinder_backend_lightbits_name: "Lightbits-NVMe-TCP"

cinder_ceph_backends:
- name: "{{ cinder_backend_ceph_name }}"
Expand Down
1 change: 1 addition & 0 deletions ansible/roles/cinder/tasks/precheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
- not enable_cinder_backend_pure_iscsi | bool
- not enable_cinder_backend_pure_fc | bool
- not enable_cinder_backend_pure_roce | bool
- not enable_cinder_backend_lightbits | bool

- name: Checking LVM volume group exists for Cinder
become: true
Expand Down
10 changes: 10 additions & 0 deletions ansible/roles/cinder/templates/cinder.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,16 @@ san_ip = {{ pure_san_ip }}
pure_api_token = {{ pure_api_token }}
{% endif %}

{% if enable_cinder_backend_lightbits | bool %}
[{{ cinder_backend_lightbits_name }}]
volume_driver: 'cinder.volume.drivers.lightos.LightOSVolumeDriver'
volume_backend_name: {{ lightbits_nvme_tcp_backend_name }}
lightos_api_address: {{ lightbits_target_ips }}
lightos_api_port: {{ lightbits_api_port}}
lightos_default_num_replicas: {{ lightbits_default_num_replicas }}
lightos_skip_ssl_verify: {{ lightbits_skip_ssl_verify }}
lightos_jwt: {{ Lightbits_JWT }}

[privsep_entrypoint]
helper_command=sudo cinder-rootwrap /etc/cinder/rootwrap.conf privsep-helper --config-file /etc/cinder/cinder.conf

Expand Down
33 changes: 33 additions & 0 deletions doc/source/reference/storage/cinder-guide-lightbits.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
.. cinder-guide-Lightbits:

=====================================
Lightbits labs storage for OpenStack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just drop the "labs" here. If you want to keep it, it needs to be capitalized, as the name is "Lightbits Labs", not "Lightbits labs".

=====================================

Lightbits labs Cinder Driver
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same and same everyone you have "labs"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuval-lb Will this change the content of this page ?
https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/lightbits-lightos-driver.html

I've plan to create patch to update these pages .

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if yes then we want to merge this patch asap.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahman-lb no, this guide will be part of the kolla-ansible project

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you, i'll take care of the other.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To use the ``Lightbits labs`` Cinder backend, enable and
configure the ``Lightbits labs`` Cinder driver in
``/etc/kolla/globals.yml``.

.. code-block:: yaml

enable_cinder_backend_lightbits: "yes"

.. end

Also set the values for the following parameters in ``/etc/kolla/globals.yml``:

- ``lightos_api_address``
- ``lightos_api_port``
- ``lightos_default_num_replicas``
- ``lightos_skip_ssl_verify``
- ``lightos_jwt``


For details on how to use these parameters, refer to the
`Lightbits labs Cinder Reference Guide <https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/lightbits-lightos-driver.html>`_.

There are numerous other parameters that can be set for this driver and
these are detailed in the above link.
3 changes: 3 additions & 0 deletions doc/source/reference/storage/cinder-guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ that appears in cinder.conf:
* - Pure Storage FlashArray for OpenStack
- cinder_backend_pure_roce_name
- Pure-FlashArray-roce
* - Lightbits Labs storage backend
- cinder_backend_lightbits_name
- Lightbits-NVMe-TCP

These are the names you use when
`configuring <https://docs.openstack.org/cinder/latest/admin/multi-backend.html#volume-type>`_
Expand Down
1 change: 1 addition & 0 deletions etc/kolla/globals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ workaround_ansible_issue_8743: yes
#enable_cinder_backend_pure_iscsi: "no"
#enable_cinder_backend_pure_fc: "no"
#enable_cinder_backend_pure_roce: "no"
#enable_cinder_backend_lightbits: "no"
#enable_cloudkitty: "no"
#enable_collectd: "no"
#enable_cyborg: "no"
Expand Down