Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch pepy to pypi downalod badge #18345

Merged
merged 3 commits into from
Aug 21, 2023
Merged

switch pepy to pypi downalod badge #18345

merged 3 commits into from
Aug 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 18, 2023

What does this PR do?

Resolves #18340 (comment)
the pepy badge was recently unstable and often returned 404 so this is a replacement that does not have total downloads, only per the last period...

PyPI - Downloads

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

@Borda Borda added this to the 2.0.x milestone Aug 18, 2023
@github-actions github-actions bot added fabric lightning.fabric.Fabric app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Aug 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 link-check
Check ID Status
check-md-links / markdown-link-check success

These checks are required after the changes to README.md, src/lightning_app/README.md, src/lightning_fabric/README.md, src/pytorch_lightning/README.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Aug 18, 2023
@Borda
Copy link
Member Author

Borda commented Aug 20, 2023

Ref: psincraian/pepy#573

@Borda Borda merged commit 2be0ac5 into master Aug 21, 2023
17 checks passed
@Borda Borda deleted the readme/pip-badge branch August 21, 2023 16:47
Borda added a commit that referenced this pull request Aug 28, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 2be0ac5)
lantiga pushed a commit that referenced this pull request Aug 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 2be0ac5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants