Remove the file existence check in TorchCheckpointIO #19344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19344 +/- ##
==========================================
- Coverage 84% 54% -30%
==========================================
Files 448 443 -5
Lines 37876 37778 -98
==========================================
- Hits 31640 20311 -11329
- Misses 6236 17467 +11231 |
for more information, see https://pre-commit.ci
awaelchli
changed the title
awaelchli
changed the title
Borda
approved these changes
Jan 25, 2024
carmocca
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, calling the
TorchCheckpointIO.remove_checkpoint()with a file path that doesn't exist would silently pass. This could be seen as undesired. Furthermore, as a side-effect of the.exists()check, it would silently fail on symlinks that point to a target that doesn't exist, and thus not delete the symlink at all. These two observations surfaced in the custom ModelCheckpoint implementation in NeMo, which resulted in unexpected behavior.For our ModelCheckpoint implementation, the change in this PR doesn't matter, because our logic only deletes files that exist.
📚 Documentation preview 📚: https://pytorch-lightning--19344.org.readthedocs.build/en/19344/
cc @carmocca @justusschock @awaelchli @Borda