-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC: Switch map operator arguments order #19345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
changed the title
BC: Switch map operator order
BC: Switch map operator arguments order
Jan 25, 2024
ethanwharris
approved these changes
Jan 25, 2024
andyland
approved these changes
Jan 25, 2024
yurijmikhalevich
approved these changes
Jan 25, 2024
awaelchli
pushed a commit
that referenced
this pull request
Jan 30, 2024
update Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
lexierule
pushed a commit
that referenced
this pull request
Jan 31, 2024
update Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR switches the order of the arguments passed to the function for the map operator.
This is meant to make it more logical as input -> output are usually thought from left to right. Suggestion from @williamFalcon
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19345.org.readthedocs.build/en/19345/
cc @Borda