Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: Torch 2.5 #20351

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

bump: Torch 2.5 #20351

wants to merge 9 commits into from
+89 −63

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 19, 2024 •
edited by github-actions bot
Loading

What does this PR do?

aligning with the recent release of PT 2.5

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20351.org.readthedocs.build/en/20351/

cc @tchaton @Borda @justusschock @awaelchli

@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file dockers labels Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4) failure ❌
pl-cpu (macOS-14, lightning, 3.12, 2.5) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4) failure ❌
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5) failure ❌
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2) failure ❌
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4) failure ❌
pl-cpu (windows-2022, lightning, 3.12, 2.5) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-13, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/core/module.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/utilities/test_imports.py.

🔴 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) failure ❌
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/core/module.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/utilities/test_imports.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to .azure/gpu-benchmarks.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/__init__.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/core/module.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

🟡 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1, 12.1.0) no_status ❓
build-cuda (3.11, 2.2, 12.1.0) no_status ❓
build-cuda (3.11, 2.3, 12.1.0) no_status ❓
build-cuda (3.12, 2.4, 12.1.0) no_status ❓
build-cuda (3.12, 2.5, 12.1.0) no_status ❓
build-pl (3.10, 2.1, 12.1.0) success ✅
build-pl (3.11, 2.2, 12.1.0) success ✅
build-pl (3.11, 2.3, 12.1.0) success ✅
build-pl (3.12, 2.4, 12.1.0) no_status ❓
build-pl (3.12, 2.5, 12.1.0) success ✅

These checks are required after the changes to .github/workflows/docker-build.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt.

🔴 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.5) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.4) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.5) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2) failure ❌
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.5) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-13, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, tests/tests_fabric/utilities/test_imports.py, .github/workflows/ci-tests-fabric.yml.

🔴 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) failure ❌

These checks are required after the changes to .azure/gpu-tests-fabric.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, tests/tests_fabric/utilities/test_imports.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/typing.txt, src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-13, fabric, 3.9) success ✅
install-pkg (macOS-13, fabric, 3.11) success ✅
install-pkg (macOS-13, pytorch, 3.9) success ✅
install-pkg (macOS-13, pytorch, 3.11) success ✅
install-pkg (macOS-13, lightning, 3.9) success ✅
install-pkg (macOS-13, lightning, 3.11) success ✅
install-pkg (macOS-13, notset, 3.9) success ✅
install-pkg (macOS-13, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/typing.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (3627c5b) to head (76b00d8).

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #20351    +/-   ##
========================================
- Coverage      89%      87%    -2%     
========================================
  Files         267      267            
  Lines       23065    23068     +3     
========================================
- Hits        20574    20059   -515     
- Misses       2491     3009   +518

@Borda Borda added the priority: 0 High priority task label Oct 21, 2024
@t-vi
Copy link
Contributor

t-vi commented Nov 6, 2024

Nit: we probably should go to 2.5.1

@t-vi t-vi mentioned this pull request Nov 6, 2024
Open
@Borda Borda changed the title bump: Torch 2.5.0 bump: Torch 2.5 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file dockers fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @t-vi