forked from Monkestation/Monkestation2.0
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PORT] Updates Node bootstrapping to v20 (Monkestation#2360)
* Creates a node compatibility mode (#82334) ## About The Pull Request By default this will install node v20 LTS, but if a user is detected to be using win 7 it's node v14 This lets us run higher node versions (with presumably more stable and performant content) while allowing win 7 users to play I should note that this is making clean tgui builds run at ~6.7sec which is about a 6.9% speed increase (nice) from the previous #80310 ## Why It's Good For The Game Better tools ## Changelog N/A nothing player facing * Compiling the servers works again (#82420) "Compat" node version didn't work at all * Reimplements node compatibility mode (#83141) ## About The Pull Request Puts a switch inside our build tools that will download the appropriate node version based on your OS. #82334 ## Why It's Good For The Game Closes #83076 Allows players to play the game * Node Bootstrap: Cast OS version to int so compat code works (#83190) This wasn't working for me because `OSMajor` was set to a string, not a number, so it failed the if check. Making this change made it work --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
- Loading branch information
1 parent
960f561
commit e1e86c4
Showing
5 changed files
with
21 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
/yarn.lock | ||
/.pnp.* | ||
|
||
.swcrc | ||
/docs | ||
/public | ||
/packages/tgui-polyfill | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters