Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Weird stroke behavior near input #782

Open
1 task done
timkrief opened this issue Jan 9, 2025 · 7 comments
Open
1 task done

[Bug]: Weird stroke behavior near input #782

timkrief opened this issue Jan 9, 2025 · 7 comments
Assignees
Labels
bug Something isn't working confirmed good first issue Good for newcomers help wanted Extra attention is needed

Comments

@timkrief
Copy link

timkrief commented Jan 9, 2025

What happened?

A bug happened!

It seems like there is a really weird behavior with the stroke near the input the line is not static it feels like there are some data points missing or changing or something. It's easier to spot with large thickness, but it's always there.

It's not an aesthetic issue, it's a functional one, it messes the final stroke look.

Screen_Recording_20250109_034647_1.mp4

I inclueded a video to make it clearer.

Thanks for this app!

Version

2.2.3

Platform

Android

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@timkrief timkrief added the bug Something isn't working label Jan 9, 2025
@github-project-automation github-project-automation bot moved this to 📕 Todo in Butterfly Jan 9, 2025
@CodeDoctorDE
Copy link
Member

Yes this is a Side effect of the stroke algorithm I use.

Can you try these values:
image-2.png

@timkrief
Copy link
Author

timkrief commented Jan 9, 2025

Hi, I tried with a lot of different settings, here's with the settings you suggested:

Screen_Recording_20250109_120848_1.mp4

@timkrief
Copy link
Author

timkrief commented Jan 9, 2025

Here's another example. this time it became really laggy at the end.

Screen_Recording_20250109_121911_2.mp4
Screen_Recording_20250109_121911_3.mp4

Image

@CodeDoctorDE
Copy link
Member

Hmm i see, but im currently not really familiar with the algorithm to fix this.
If you want to look at this, im using the perfect freehand library https://github.com/steveruizok/perfect-freehand-dart

@timkrief
Copy link
Author

timkrief commented Jan 9, 2025

Noted, I'll take a look 🙂

@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Jan 9, 2025

Thanks, i see you also have a programming background. I dont know if the library authors accept pull requests. If not, we could make a fork out of this

@CodeDoctorDE CodeDoctorDE added good first issue Good for newcomers help wanted Extra attention is needed confirmed labels Jan 9, 2025
@CodeDoctorDE
Copy link
Member

Some more info if you want to work on that:
I'm using the exact library version CodeDoctorDE/perfect-freehand-dart@6228363 (which is the same 2.3.2 as on pub.dev except I just have it as git dependency).

This is the part of the code which calculates how the points looks like:

var outlinePoints = freehand.getStroke(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: 📕 Todo
Development

No branches or pull requests

2 participants