Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update solvable state when solving with assumptions #9

Open
Lipen opened this issue Jan 23, 2022 · 0 comments
Open

Do not update solvable state when solving with assumptions #9

Lipen opened this issue Jan 23, 2022 · 0 comments

Comments

@Lipen
Copy link
Owner

Lipen commented Jan 23, 2022

JMiniSat::solvable field should not be updated when solving with assumptions: https://github.com/Lipen/kotlin-satlib/blob/master/jni/src/main/kotlin/com/github/lipen/satlib/jni/solver/JMiniSat.kt#L187-L190

For example, when the problem is UNSAT under assumptions, it still might be "solvable" without those assumptions, but currently it gets flagged as solvable=false. It is not possible (afaik) to distinct between "UNSAT because of assumptions" and "UNSAT because of all added clauses", so maybe solve(assumptions) should not touch the solvable field at all.

The same goes for JGlucose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant