refactor: using virtual function check actor type

LiteLDev · Feb 17, 2024 · d38c5cf · d38c5cf
1 parent c05c2e7
commit d38c5cf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/ll/api/event/player/PlayerPlaceBlockEvent.cpp b/src/ll/api/event/player/PlayerPlaceBlockEvent.cpp
@@ -37,7 +37,7 @@ LL_TYPE_INSTANCE_HOOK(
     ItemStackBase const& item,
     bool                 genParticle
 ) {
-    if (actor.hasCategory(ActorCategory::Player)) {
+    if (actor.isPlayer()) {
         auto event = PlayerPlacingBlockEvent{static_cast<Player&>(actor), blockpos, face};
         EventBus::getInstance().publish(event);
         if (event.isCancelled()) {

diff --git a/src/mc/deps/core/string/HashedString.h b/src/mc/deps/core/string/HashedString.h
@@ -120,8 +120,6 @@ class HashedString {
     }
 
     // Convertors
-    [[nodiscard]] constexpr operator std::string&() { return str; } // NOLINT
-
     [[nodiscard]] constexpr operator std::string const&() const { return str; } // NOLINT
 
     [[nodiscard]] constexpr operator std::string_view() const { return std::string_view(str); } // NOLINT