Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml_live not updated upon changes #371

Closed
lborcard opened this issue Aug 5, 2024 · 6 comments
Closed

toml_live not updated upon changes #371

lborcard opened this issue Aug 5, 2024 · 6 comments

Comments

@lborcard
Copy link

lborcard commented Aug 5, 2024

Dear Readfish team,

I am testing your toml_live option but since the documentation does not cover exactly how to use it (to my knowledge) is there anything covering this topic?
I tried to create a toml file using my.toml_live and then modify it during a simulated run but to no avail. I could not see any trace of an update of the TOML file.

What did I do wrong?
best,

Loïc

Copy link

github-actions bot commented Aug 5, 2024

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@mattloose
Copy link
Contributor

Hi,

You create a toml as normal, but then during a run add a new toml with the same name but _live at the end.

This should work, but as you know it's not extnesively documented at present.

I'd run on a playback run first and test. You should see a message in the logs when the toml file is re-read.

@alexomics
Copy link
Contributor

The live toml file should have the same name as the original with _live added at the end of the .toml extension. So:

exp.toml
exp.toml_live

Can you confirm that you have followed this naming scheme? Also, when reloading the TOML if the _live is not valid it is ignored, but readfish will attempt to reload each iteration.

@lborcard
Copy link
Author

lborcard commented Aug 5, 2024

ok thank you very much ! now this toml can further modified and each modification will be noticed?

@mattloose
Copy link
Contributor

Yes - as long as the toml file is valid it will be loaded on each iteration - but currently we don't check the validity and it's left to the user to make sure that the file is valid.

@lborcard
Copy link
Author

lborcard commented Aug 5, 2024

alright perfect thank you very much!

@Adoni5 Adoni5 closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants