Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /fly, /abortion and many type definitions to libtrx #1534

Merged
merged 7 commits into from
Sep 22, 2024
Merged

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 21, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

LostArtefacts/libtrx#33

@rr- rr- added TRX bug A bug with TRX Internal The invisible stuff labels Sep 21, 2024
@rr- rr- added this to the 4.5 milestone Sep 21, 2024
@rr- rr- requested review from a team as code owners September 21, 2024 11:11
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 21, 2024 11:12
@rr- rr- self-assigned this Sep 21, 2024
@aredfan
Copy link
Collaborator

aredfan commented Sep 21, 2024

I found a small bug. When you use /abortion in Lara's Home, dynamite sprites will appear, this is probably because there's no explosion sprite present in the level.

1

In the latest dev snapshot (4.4-4-g451e619) these sprites are hidden from view.

@lahm86
Copy link
Collaborator

lahm86 commented Sep 21, 2024

The dynamite sprite is in the explosion slot (151) in the level file, and this is also the case in Vilcabamba. Other levels like Caves don't have it at all.

@rr-
Copy link
Collaborator Author

rr- commented Sep 22, 2024

@aredfan @lahm86 fixed. Explosions in levels that had missing sprites and sounds should now only appear when using cheats – the mummies should behave as they previously did.

@aredfan
Copy link
Collaborator

aredfan commented Sep 22, 2024

@rr- There's just 2 levels remaining that lack explosions for Lara, both are in the Egyptian segment of TRUB.

@rr-
Copy link
Collaborator Author

rr- commented Sep 22, 2024

@aredfan fixed. Also tidied injections up a bit.

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explosions are working as expected in all 19 levels of TR1/UB. I've also checked to make sure the mummies are unaffected in this PR.

LGTM, and thank you. 👍

@rr- rr- merged commit 452ebad into develop Sep 22, 2024
6 checks passed
@rr- rr- deleted the libtrx-console branch September 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff TR1 TR2 TRX bug A bug with TRX
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants