-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRX merger #1553
TRX merger #1553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works great! Amazing. I just had to delete my old Docker containers and run a just clean
.
Only minor things I noticed:
just
alone only builds TR1X. I guess that's an ok default to have?docs/tr1/CONTRIBUTING.md
anddocs/tr2/CONTRIBUTING.md
should probably be slightly updated to explicitly mentionjust-tr1-...
andjust-tr2-...
.- I don't fully understand how
just lint
etc work now. Does the command lint both TR1X and TR2X? TheCONTRIBUTING.md
could also maybe reflect this answer too.
Thanks, changed this to also build TR2.
Actually these two documents got merged to
Correct – it formats all the code. Similarly autogenerated code is updated on each pre-commit trigger. |
Checklist
Description
Merges TRX and libtrx into a single repository. Doesn't preserve the commit history, which we regarded as an acceptable loss.
Remaining to be done after the merge: