misc: reconfigure UI toggling mechanism #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow making specific UI hiding settings rather than a global catch-all.
This makes a general UI hiding function available in libtrx, expecting the relevant specific config setting to be provided. For TR1, the call is moved away from shell.c into Game_ProcessInput.
This introduces a separate UI state setting for photo mode only.
lahm86
added
Internal
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
rr-
approved these changes
Oct 7, 2024
aredfan
approved these changes
Oct 7, 2024
walkawayy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue raised as this is all unreleased so far. As this renames the previous general UI option, your current setting will be reset effectively.
Checklist
Description
This separates the general game UI state and photo mode UI state settings, and provides a mechanism for any future cases where specific UIs need to be togglable. There is perhaps a better place than the common UI module for the function, LMK what you think.