Decompile skidoo #1733
Decompile skidoo #1733
Conversation
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
rr-
force-pushed
the
tr2-decomp-skidoo
branch
from
8e5e0fa
to
5ce797c
Compare
|
Download the built assets for this pull request: |
src/tr2/decomp/skidoo.c
Outdated
| fx->object_id = O_EXPLOSION; | ||
| } | ||
|
|
||
| Effect_ExplodingDeath(g_Lara.skidoo, ~SKIDOO_GUN_MESH, 0); |
There was a problem hiding this comment.
If either the red or black skidoo explodes, you see the main part of the red mesh appear. In OG, you only see "side bits" of the model fly off. Possibly the mesh_bits here aren't quite right for this call?
There was a problem hiding this comment.
Thanks – the value indeed was wrong, rather than ~4 it should've been -4 or ~(4 - 1). I have pushed a correction, but I'm unable to test it at the moment and would appreciate info if it was enough to fix the issue.
There was a problem hiding this comment.
BTW the name SKIDOO_GUN_MESH I think is wrong and should be changed – but I don't fully understand its usage. For sure it has to do with the track mesh, but I'm not certain as to why track_mesh & 4 yields a truthy value for armed snowmobiles and a falsy value for normal snowmobiles.
There was a problem hiding this comment.
Hmm, I don't follow it either TBH. Will need some studying.
It failed to recognize function pointer arguments.
rr-
force-pushed
the
tr2-decomp-skidoo
branch
from
5ce797c
to
6a6872e
Compare
|
There's a desync in demo 3 - the skidoo misses a small jump 3 seconds into the video. Latest dev snapshot: Video.1.mp4PR: Video.2.mp4 |
Checklist
Description
#1691