lara: fix jump-twist state softlock #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM. @walkawayy @lahm86 what do you think about publishing the current develop as a hotfix 2.15.1?
That sounds good to me. The only way currently you could workaround this softlock would be to enter and exit DOZY, but that's obviously not ideal. |
|
Ya hotfix sounds good. I'm afk for a bit so I can't test right now. |
|
Please LMK here or in Discord once this gets merged so that I can do the release. |
Apologies, I got distracted. Should be good to go 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #889.
Checklist
Description
I discovered I had missed the collision routine for twists in #802, so I believe this bug was a result of unknown behaviour there. In addition to this, I have added guards to the post-twist animations to ensure that if Lara is on the floor, her goal state should no longer be twist. It is a very difficult bug to reproduce, but Eycore provided a save with the issue and this fix allows that save to be played from again, plus I have not been able to reproduce the bug again after testing several scenarios.
Thanks as well to @Trxyebeep for input on this issue.