items: avoid changing const hitpoints #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #892.
Regression from #888.
Checklist
Description
The previous clamping method was setting hitpoints to -16383, so the condition below was passing and hence Natla's control was treating her as already dead instead of initiating the semi-death countdown timer.
https://github.com/LostArtefacts/Tomb1Main/blob/develop/src/game/objects/creatures/natla.c#L86
To avoid further issues, if an item's hitpoints value is
DONT_TARGETno further changes will be made to it. For normal cases, we clamp to 0. I've tested each enemy's death, Lara's own death, shooting the scion and the mummy in Qualopec.