Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bear: fix the bear pat attack so it does not miss Lara #903

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

walkawayy
Copy link
Collaborator

@walkawayy walkawayy commented Jul 30, 2023

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Fixed the bear pat attack so it does not miss Lara. Fix done by ChocolateFan.
Does not solve all the things listed in the original issue because they were user preferred behavior changes and not really bug fixes. Requesting translations.

@walkawayy walkawayy added the OG bug A bug in original game label Jul 30, 2023
@walkawayy walkawayy added this to the 2.16 milestone Jul 30, 2023
@walkawayy walkawayy requested review from rr- and lahm86 July 30, 2023 23:29
@walkawayy
Copy link
Collaborator Author

@ajtudela another translation request please:
Fixes bear pat attack so it does not miss Lara.

@walkawayy walkawayy linked an issue Jul 30, 2023 that may be closed by this pull request
@ajtudela
Copy link
Contributor

@ajtudela another translation request please:

Could you explain me this fix so I can make a better translation?

@walkawayy
Copy link
Collaborator Author

walkawayy commented Jul 31, 2023

@ajtudela another translation request please:

Could you explain me this fix so I can make a better translation?

It fixes when the bear is on its hind legs and "pats" Lara. The range is bugged so it does not damage. That's the name for the attack in the code. Here's the relevant video from the issue:

bear-pat-broken.mp4

Here's a random gif of a dog "patting" another dog.

https://64.media.tumblr.com/10591d32af065d3b671836043b7a6f01/tumblr_p8dbscYrKt1vb46leo1_400.gif

@rr-
Copy link
Collaborator

rr- commented Jul 31, 2023

@ajtudela
Copy link
Contributor

Nice gif, hahaha

The translation would be:

Corrige el ataque del oso para que golpee a Lara.

@walkawayy walkawayy merged commit bcff926 into LostArtefacts:develop Jul 31, 2023
1 check passed
@walkawayy walkawayy deleted the bear-atk branch August 1, 2023 00:16
rr- pushed a commit that referenced this pull request Aug 15, 2023
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game TR1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: issues with BEAR_ATTACK1 and BEAR_ATTACK2
3 participants