installer: overwrite all essential files #907
Conversation
| Overwrites any files such as level data, music files and existing user settings. | ||
| If this option is off, only overwrites Tomb1Main.exe in order to update the game. | ||
| Overwrites any files such as level data and music files. If this option is off, only | ||
| overwrites Tomb1Main.exe and other essential files in order to update the game. |
There was a problem hiding this comment.
I don't think this checkbox does anything given the new changes – the release .zip contains only files from the new
extensions whitelist?
There was a problem hiding this comment.
There are the three PNG files too - eidospc.png, titleh.png and titleh_ub.png. Should we just remove the checkbox altogether?
Actually, the setting is also used here, so I suppose that ensures music and level files are retained.
There was a problem hiding this comment.
IMO we should remove this box altogether, and the "install source" shouldn't overwrite the files whereas tomb1main files should. What do you think about this?
There was a problem hiding this comment.
Sounds good, I'll work on updating it.
There was a problem hiding this comment.
Updates now in place:
- Everything in the Tomb1Main embedded zip file will always be written to the target.
- Install source will only write files that aren't in the target folder already.
- Downloaded music and UB files will not be written if they already exist.
Resolves #904.
Checklist
Description
Changed the overwrite check approach to look at extensions so to avoid listing each file (the bin files alone would make this unmanageable I think). It will only overwrite what's in the release zip anyway, so such things as
Tomb1Main.json5will remain unaffected. I included the shaders too - do you think this is OK, or given previous shader issues should we leave these out?