Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject: fix trigger types in Khamoon levels #945

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Aug 26, 2023

Resolves #942.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Converts trapdoor triggers in City of Khamoon to dummy type in rooms 31 and 34, and converts the regular trigger in room 66 in Obelisk of Khamoon to switch type.

Converted City of Khamoon trapdoor triggers in rooms 31 and 34 to dummy
type.
Converted Obelisk of Khamoon trigger in room 66 to switch type.

Resolves LostArtefacts#942.
@lahm86 lahm86 added OG bug A bug in original game Data Requires injecting content / files that are not a part of the original game labels Aug 26, 2023
@lahm86 lahm86 added this to the 2.16 milestone Aug 26, 2023
@lahm86 lahm86 self-assigned this Aug 26, 2023
@lahm86 lahm86 requested review from rr- and walkawayy August 26, 2023 09:59
Copy link
Collaborator

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, out of curiosity, could you please include a video of what was wrong with the original triggers if that's not too much trouble? Thanks

@lahm86
Copy link
Collaborator Author

lahm86 commented Aug 26, 2023

Hi, out of curiosity, could you please include a video of what was wrong with the original triggers if that's not too much trouble? Thanks

No problem - before and after for each issue shown here.

https://youtu.be/_yHji_W172I

@lahm86 lahm86 merged commit bacbddf into LostArtefacts:develop Aug 26, 2023
1 check passed
@lahm86 lahm86 deleted the issue-942-khamoon-triggers branch August 26, 2023 14:58
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OG bug: incorrect trigger types in Egypt levels
3 participants