inject: fix Atlantean Stronghold room portals #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to the Atlantean Stronghold FD injection fixes by reconfiguring the portals between rooms 74 and 12 such that the vertices are within the room bounds in all cases. This amends the injection function for this to allow targeting specific doors as there are 3 in this case. Its other use case is in Palace Midas where there is only 1 portal. Resolves LostArtefacts#227.
lahm86
added
OG bug
rr-
approved these changes
Aug 28, 2023
walkawayy
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227.
Checklist
Description
This amends the portals between rooms 74 and 12 per @SuiKaze's comments. The crash is easy to reproduce with the fly cheat if you get into this area with the flip map on. It's also entirely possibly to skip over the flipoff trigger fix highlighted below if you make a mistake and fall down, and then use a setup used by speedrunners to drop into the hole.
Demo of the crash and the fix.
https://www.youtube.com/watch?v=ye_jnebNu3U
The modified injection function here is also used in Midas to amend the height of the portal between rooms 9 and 13 (which is linked to texture fixes in this area). The change was needed as there are 3 different portals between these Stronghold rooms, but the previous approach only allowed targeting one per room pair.