Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

savegame: fix flame emitter item data save and load #956

Merged
merged 1 commit into from
Aug 31, 2023
Merged

savegame: fix flame emitter item data save and load #956

merged 1 commit into from
Aug 31, 2023

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Aug 30, 2023

Resolves #947

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Alternative implementation of #952. Rather than trying to rely on the order of loaded items, we reuse the calculated FX IDs and adjust item->data as necessary.

@rr- rr- requested review from lahm86 and walkawayy August 30, 2023 22:42
@walkawayy
Copy link
Collaborator

walkawayy commented Aug 31, 2023

Crashes for me on reload.

  1. new game
  2. pull switch to turn off emitters
  3. wait till switch comes up and emitters turn back on
  4. save
  5. load
  6. pull switch and see if everything works

image

@rr- rr- merged commit becc20f into develop Aug 31, 2023
2 checks passed
@rr- rr- deleted the b947 branch August 31, 2023 21:30
@walkawayy walkawayy added the TRX bug A bug with TRX label Aug 31, 2023
@walkawayy walkawayy added this to the 2.16 milestone Aug 31, 2023
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1 TRX bug A bug with TRX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flame emitters are not properly saved and loaded causing crashing
3 participants