This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Reusable game strings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86 and
walkawayy
and removed request for
a team
rr-
force-pushed
the
reusable-game-strings
branch
from
85e2556
to
0d395b7
Compare
The amount of bugs encountered in this software during trx development outweighs the benefits of its continued usage.
walkawayy
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I've made refactors to the game string management several times, but I just keep encountering issues. Recently, while integrating game string support into libtrx, I realized there was no way to declare the
GAME_STRING_IDenum in libtrx and allow users (TR1X, TR2X) to add their own strings (or the other way around).To address this, this PR switches from using integers to strings for keys. It maintains existing macros for minimal disruption and includes the
uthashlibrary for performance.As a result, the default string table initialization must occur at runtime, not compile time. Consumers need to declare their default strings at runtime using the new
GameString_InitandGameString_Shutdown()functions.libtrx will provide its own
game_string.deftable, which consumers will need to#includein theirGameString_InitandGameString_Shutdown()routines.Related changes: