add user-agent header and set application name #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how i feel about this build Ill test out the changes on my personal project i use this for and get back to you about this PR |
999eagle
force-pushed
the
feat/user-agent
branch
from
93ba6fe
to
88fd9df
Compare
LostQuasar
requested changes
Sep 6, 2024
src/api.rs
Outdated
| } | ||
| app_name | ||
| } else { | ||
| "rusty".to_string() |
There was a problem hiding this comment.
Suggested change
| "rusty".to_string() | |
| "rzap".to_string() |
This makes more sense than what I originally had it. Also might be worth appending the version.
There was a problem hiding this comment.
okay, changed the text. the version probably shouldn't be listed here because this text is what's shown in the openshock dashboard's log view and nothing else seems to add a version there.
…user agent string this is similar to what the official C# API bindings do, see https://github.com/OpenShock/SDK.CSharp/blob/b1bbabcbe31c684f75aa83bb619423d23fa637cc/SDK.CSharp/OpenShockApiClient.cs#L40
999eagle
force-pushed
the
feat/user-agent
branch
from
88fd9df
to
1f02c6c
Compare
|
Looks great to me I'll run some tests and figure out the changes and merge/release a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr first adds a builder pattern to
OpenShockAPIsoOpenShockAPI::newdoesn't need to have more optional arguments added and becomes unwieldy.the second commit then adds an option to configure the application name/version in the builder. this information is used in the user agent (if configured) similarly to what the official C# API bindings do. the application name is also passed as
custom_nameinpost_controlso the correct application name shows up the the logs on the OpenShock dashboard.the introduction of this builder pattern might be a bit too much? feel free to give feedback!