Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 revert loaded theme #104

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat: 🎸 revert loaded theme #104

merged 3 commits into from
Mar 22, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Mar 21, 2024

Changes:

  • Updated ThorVG to the latest v0.12.x, which includes an enhancement to slots. This update enables the removal of applied slots by passing a nullptr to the override method.
  • Updated the load_theme method in dotlottie_player to automatically revert to the default theme when an empty theme_id is passed.
let dotlottie_player = DotLottiePlayer::new(Config{...});

dotlottie_player.load_theme("dark_theme_id"); // This will load the "dark_theme_id" if it exists in the loaded .lottie asset

dotlottie_player.load_theme(""); // This will remove the previously applied theme and revert to the default animation

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: 5bdfee1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf merged commit ff2d444 into main Mar 22, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants