-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated readme #105
feat: updated readme #105
Conversation
|
README.md
Outdated
<p align="center"> | ||
<img src="./assets/design.png" alt="dotLottie architecture"/> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can include the mermaid code diagram directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theashraf Added! its really cool
README.md
Outdated
|
||
- [For your dotLottie creation and modification needs](https://github.com/dotlottie/dotlottie-js) | ||
- [Tools for parsing Lottie animations](https://github.com/LottieFiles/relottie) | ||
- [dotLottie playground for creating multi-animations dotLotties](https://dotlottie.github.io/player-component/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotLottie playground is currently utilizing the player-component
, which may become irrelevant soon as we begin the deprecation process. It's likely necessary to migrate the dotLottie playground/viewer to either the dotlottie-rs
or dotlottie-web
GitHub pages. This migration should include refactoring it from using the player-component to utilizing dotlottie-web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have removed, can add it back when we complete the repo move
@@ -12,21 +12,29 @@ | |||
|
|||
This is the Rust implementation of the dotLottie player and its related tools. It utilizes uniffi-rs to generate FFI bindings for Kotlin, Swift, and WebAssembly (WASM). these bindings are then used in the native dotLottie players for [Android](https://github.com/LottieFiles/dotlottie-android), [iOS](https://github.com/LottieFiles/dotlottie-ios), and [Web](https://github.com/LottieFiles/dotlottie-web) bringing consistency of playback and dotLottie features across all platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include:
- The problem dotlottie-rs solves (fragmentation and rendering inconsistency issues)
- The features it supports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added @theashraf please review
@@ -1,6 +1,6 @@ | |||
# dotLottie Rust | |||
|
|||
![CI](https://github.com/LottieFiles/dotlottie-rs/workflows/release/badge.svg) | |||
![CI](https://img.shields.io/github/v/release/LottieFiles/dotlottie-rs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
ff1e070
to
000dde0
Compare
No description provided.