Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 improve crates naming convention #228

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Sep 11, 2024

Changes:

  • Renamed dotlottie-rs lib name from dotlottie-player-core to dotlottie-rs
  • Renamed dotlottie-ffi to dotlottie-uniffi for clarity, indicating that these bindings are generated using uniffi
  • Updated Makefile build system and gh workflows to reflect the renaming and refactoring

fixes #106

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: b3a5cdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf changed the title refactor: 💡 improve crates naming convension refactor: 💡 improve crates naming convention Sep 11, 2024
@theashraf theashraf requested review from samuelOsborne and afsalz and removed request for samuelOsborne September 12, 2024 03:07
@theashraf theashraf merged commit 43ee0ac into main Sep 17, 2024
1 check passed
@theashraf theashraf deleted the chore/rename-crates branch September 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File/module naming under the same naming convention
2 participants