Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made thorvg an optional dependency #248

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dragostis
Copy link
Contributor

This makes building the crate easier without having Conan installed and it should enable docs being generated on docs.rs.

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 9550c50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dragostis dragostis force-pushed the feat/optional-thorvg branch 4 times, most recently from 4048c66 to 0912481 Compare October 17, 2024 12:00
This makes building the crate easier without having Conan installed
and it should enable docs being generated on docs.rs.

As a bonus, this also removes all the ThorVG FFI from the public
API.
Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dragostis !! 🚀

@theashraf theashraf merged commit aa4a152 into LottieFiles:main Oct 18, 2024
1 check passed
samuelOsborne added a commit that referenced this pull request Nov 8, 2024
* bug: fix for builds performed apple hosts (#229)

Co-authored-by: Muhmud Ahmad <muhmud.ahmad@toptal.com>

* feat: c-api (#237)

* feat: c-api

---------

Co-authored-by: Muhmud Ahmad <muhmud.ahmad@toptal.com>

* chore: fix wasm build (#238)

* chore: fix wasm build

* chore: fixes for c-api build issues (#239)

* chore: fixes for c-api build issues

---------

Co-authored-by: Muhmud Ahmad <muhmud.ahmad@toptal.com>

* chore: fix undefined symbol _emscripten_get_now for wasm compatibility (#241)

* chore: Update emscripten bindings and Cargo.toml dependencies

Signed-off-by: Abdelrahman Ashraf <a.theashraf@gmail.com>

* chore: 🤖 upgrade uniffi_bindgen_cpp to v0.6.3+v0.25.0

* chore: Update EMSDK version to 3.1.68

---------

Signed-off-by: Abdelrahman Ashraf <a.theashraf@gmail.com>

* chore: 🤖 upgrade thorvg to v0.15.0 (#240)

* chore: 🤖 upgrade thorvg to v0.15.0

* chore: Release 0.1.32 (#242)

Co-authored-by: GitHub <github-actions@github.com>

* fix: removed unused lib.rs file (#247)

* feat: made thorvg an optional dependency (#248)

This makes building the crate easier without having Conan installed
and it should enable docs being generated on docs.rs.

As a bonus, this also removes all the ThorVG FFI from the public
API.

* chore: fix wasm build (#249)

* feat: update thorvg to version 0.15.2 (#255)

* feat: updated parser to new forma

* refctor: added state machine parsing and creation (#232)

* refactor: merged json and state machine enums together (#233)

* feat: transition logic for triggers and events (#234)

* feat: added trigger transition logic without events, added infinite loop handler

* feat: added event transition logic

* feat: updated tui example with different types of inputs

* feat: added many improvements to the tui example (#235)

* feat: global state (#236)

* feat: added global state logic, initial state fix

* feat: integrated global_state evaluation logic

* fix: re-entering current state on event when not needing one

* feat: actions and state entry_actions (#243)

* feat: actions can now execute changes on to the trigger and player. Including them inside the evaluate loop is not yet complete.

* feat: entry_actions working

* feat: implemented more actions, along with optionally fetching value from triggers if needed

* feat: added tests for actions

* fix: fire entry_action for global and normal state

* feat: listeners (#245)

* feat: listener foundations, renamed events

* feat: added listener unit tests

* chore: cleanup

* feat: added triggers to work with compare_to (#251)

* fix: made animationId mandatory, keys to camelCase (#252)

* feat: guardless transitions (#246)

* feat: listener foundations, renamed events

* feat: added listener unit tests

* feat: added guardless transitions, security check

* feat: updated UDL

* chore: added guard tests

* feat: updated bindgs

* feat: updated bindgs

* feat: updated bindings

* feat: logic for propagating events as well as state actions

* fix: test file

* chore: rebased, fixed guard tests

* feat: added scenario test cases, few small fixes

feat: adding debug for mobile

fix: bindings

fix: bindings

fix: bindings

* fix: ignore undefined symbols flag

* fix: tui

* fix: C API

* fix: return values for setting triggers

* fix: udls

* fix: udls

* fix: returned to arc for sm sub/unsub

* fix: merge fixes

---------

Signed-off-by: Abdelrahman Ashraf <a.theashraf@gmail.com>
Co-authored-by: Muhmud Ahmad <muhmud@users.noreply.github.com>
Co-authored-by: Muhmud Ahmad <muhmud.ahmad@toptal.com>
Co-authored-by: Abdelrahman Ashraf <a.theashraf@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub <github-actions@github.com>
Co-authored-by: Dragoș Tiselice <dragos@rive.app>
Co-authored-by: Dragoș Tiselice <dragostiselice@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants