Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 optimize wasm binary for size #73

Merged
merged 12 commits into from
Feb 21, 2024
Merged

chore: 🤖 optimize wasm binary for size #73

merged 12 commits into from
Feb 21, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Feb 1, 2024 •
edited
Loading

  • Optimizing the ffi crate release binary for size resulted in a decrease of -200KB in the overall wasm size. For more details about the optimizations applied, you can refer to this link: https://github.com/johnthagen/min-sized-rust
  • Remove unused methods/traits from the udl and emscripten bindings

Before
image

After
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c7b6d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf marked this pull request as ready for review February 1, 2024 16:29
afsalz
afsalz approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@theashraf theashraf marked this pull request as draft February 2, 2024 03:13
@theashraf theashraf added the wip label Feb 2, 2024
@theashraf theashraf removed the wip label Feb 7, 2024
@theashraf theashraf marked this pull request as ready for review February 7, 2024 06:46
@theashraf theashraf merged commit aca601c into main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsalz afsalz afsalz approved these changes

@samuelOsborne samuelOsborne samuelOsborne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theashraf @samuelOsborne @afsalz