Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 markers #89

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: 🎸 markers #89

merged 2 commits into from
Mar 6, 2024

Conversation

theashraf
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 10f75e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf marked this pull request as ready for review March 5, 2024 16:04
samuelOsborne
samuelOsborne reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@samuelOsborne samuelOsborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @theashraf! I noticed that resetting the config over using the proposed method setMarker(markerName: String) was used, do you want to implement setMarker or leave it?

@theashraf
Copy link
Member Author

Looks good @theashraf! I noticed that resetting the config over using the proposed method setMarker(markerName: String) was used, do you want to implement setMarker or leave it?

setMarker is for the platforms (web, mobile) to implement similar to setSpeed, and setMode,... etc. Not the concern of the dotlottie-rs

@theashraf theashraf merged commit 383a251 into main Mar 6, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelOsborne samuelOsborne samuelOsborne approved these changes

@afsalz afsalz Awaiting requested review from afsalz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theashraf @samuelOsborne