fix: 🐛 segmentation fault when LottieRender is dropped #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
When the
DotLottiePlayer
instance is dropped from memory and a new instance is created, there is a rapid increase in memory usage, resulting in a memory leak.Solution
Calling
tvg_canvas_clear(true)
should remove the paints instances from memory. Therefore, all that needs to be done is to invoketvg_animation_del
when the Animation instance is released.Also ensure that
tvg_canvas_clear(true)
followed bytvg_canvas_destroy
is called to drop the canvas properly. This will ensure that theAnimation
,Canvas
, and any paints pushed to the canvas, such asPicture
andBackground
shape, are completely freed from memory, and we don't have to drop them individually.