Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of minor changes/fixes #29

Open
astrobokonon opened this issue May 28, 2019 · 6 comments
Open

Collection of minor changes/fixes #29

astrobokonon opened this issue May 28, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@astrobokonon
Copy link
Member

astrobokonon commented May 28, 2019

This will probably be easier to just add them as I get them, then strike them thru when they're done.

This might turn out to be a sort of Ship of Theseus issue.

@astrobokonon astrobokonon added enhancement New feature or request low priority labels May 28, 2019
@astrobokonon astrobokonon self-assigned this May 28, 2019
@astrobokonon
Copy link
Member Author

astrobokonon commented May 28, 2019

  • Add date to clock
  • Add back the reference epoch
  • Flop sunrise/sunset in the table
  • Combine table coordinates when possible (e.g. "RA DEC Epoch Frame" instead of individual entries)

@astrobokonon
Copy link
Member Author

astrobokonon commented May 28, 2019

@astrobokonon
Copy link
Member Author

astrobokonon commented May 30, 2019

Adding back in the reference epoch was tricker than I imagined.

I initially was too sloppy when making the XML schema for the TCS topic, and there were some keys that had a bad datatype association that probably worked once and then never again. Specifically, I was storing some of the coordinate-seconds components as xsd:int when they should have been xsd:decimal and for some reason the reference epoch keys were flagged as xsd:dateTime when they really shouldn't have been. Details are in ligmos@4c44c8f.

Technically, I could have abandoned that measurement in place and switched any queries over to the tcs.loisTelemetry topic's set of information. But that would just screw myself in about 3-6 months from now when I run into another as-yet-undiscovered problem, so I had to just suck it up and deal with it now.

Unfortunately, there's no good/easy way to fix the fields in the database selectively. I could have copied the good fields into a new measurement, dropped the old one, then moved it back to the original metric name and let the database fill up again. But that's too much hassle so I just dropped the whole thing and will start fresh from here.

Lesson learned! (hopefully)

@astrobokonon
Copy link
Member Author

astrobokonon commented May 30, 2019

  • Add tracking rates

Note that this one isn't actually in any TCS status packet, it seems to be only captured as a property/value in the originating target packet. I'll have to snoop the NewScienceTargetSV topic, I think, and see if there's a schema that will actually work for easy parsing. I'm a bit worried that since it's coming from each instrument, there will be some ... heterogeneity.

  • deveny packet:
<newScienceTarget>
    <demandRADec>
        <declination>
            <degreesDec>1</degreesDec>
            <minutesArc>39</minutesArc>
            <secondsArc>2.1</secondsArc>
        </declination>
        <equinoxPrefix>B</equinoxPrefix>
        <equinoxYear>2000</equinoxYear>
        <frame>FK4</frame>
        <ra>
            <hours>12</hours>
            <minutesTime>23</minutesTime>
            <secondsTime>49.94</secondsTime>
        </ra>
    </demandRADec>
    <pointingOriginX>8.9</pointingOriginX>
    <pointingOriginY>-2.53</pointingOriginY>
    <scienceTargetConfiguration>
        <fracrate>1</fracrate>
        <rotator>
            <rotPA>180</rotPA>
            <rotatorFrame>Fixed</rotatorFrame>
        </rotator>
        <target class="TCSDataDefinitions.TCSCommand.TargetConfiguration.Target.FixedTarget.RADecTarget">
            <raDecParameters>
                <declination>
                    <degreesDec>1.6508611111111</degreesDec>
                    <minutesArc>0</minutesArc>
                    <secondsArc>0</secondsArc>
                </declination>
                <equinoxPrefix>J</equinoxPrefix>
                <equinoxYear>2000</equinoxYear>
                <frame>FK5</frame>
                <ra>
                    <hours>12.39725</hours>
                    <minutesTime>0</minutesTime>
                    <secondsTime>0</secondsTime>
                </ra>
            </raDecParameters>
            <parallax_Arcsec>0</parallax_Arcsec>
            <properMotion>
                <epochPM_Yr>2000</epochPM_Yr>
                <pmdec_ArcsPYr>0</pmdec_ArcsPYr>
                <pmra_SPYr>0</pmra_SPYr>
            </properMotion>
            <rv_kps>0</rv_kps>
            <targetName>HD107878</targetName>
            <difftrack class="TCSDataDefinitions.TCSCommand.TargetConfiguration.Target.DifftrackRADec">
                <dDec_ArcsPS>0</dDec_ArcsPS>
                <dRA_sps>0</dRA_sps>
            </difftrack>
        </target>
        <targetConfigName>HD107878</targetConfigName>
        <wl_microns>0.5</wl_microns>
        <commandID>193470169</commandID>
        <tcsErrorResponse>
            <status>false</status>
            <code>0</code>
            <source></source>
        </tcsErrorResponse>
    </scienceTargetConfiguration>
    <trackID>58637.224354</trackID>
</newScienceTarget>

@astrobokonon
Copy link
Member Author

astrobokonon commented May 31, 2019

  • Add current weather values ... somewhere (currently under each weather plot in a separate bokeh table)

@astrobokonon
Copy link
Member Author

astrobokonon commented Jun 22, 2019

  • Add in some sort of delimiter between RA/Dec. Probably requires switching to a monospace font so it doesn't jump all over the place every update
  • Break out sunrise/sunset/twilight times to a different table
  • Remove total focus offset from table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant