-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in inspector when selecting a database asset #20
Comments
Weird... I guess the method signature was changed again. |
Bump |
I tried looking into this, but I'm not exactly sure how this method is to be used. When I "F12" But maybe this is what's going wrong: this line is executed because Hope this helps! |
Seems like they did add another parameter then. I tried replicating this on the Unity6 preview but didnt run into this issue.
That class is part of teh SerializedDictionary package, so I didnt really look at it besides when I ran into the issue of it expecting two instead of one parameter on 2022 and above -- does everything still look right visually in the inspector when you just return false, specifically the databases and SceneCommands / SceneAnimations fields on the TMPWriter / TMPAnimator respectively? Also, can you go ahead and test what happens if you pass in the boolean outside of the array? So |
Bump |
I'll try this when I get back on my project, hopefully later this week. |
That doesn't work, the only legal headers in my version are:
and
I've updated to 0.1.5 (I think that's right, even though the tag in git says 1.0.5), I've thrown away my /Library/ folder just in case. That didn't change anything. This is what I'm seeing if I just return false from my try/catch: Of course, I'm not exactly sure what I'm supposed to see, but I guess that all looks okay? Let me know if I can help further testing. |
Yeah, those all look right. I guess Ill add a return false as a fallback for when none of the signatures match the cases. Only other idea I have without testing it myself is to do
Fark, I messed up the versioning. Next version will be 1.0.6 then :D |
Not using this package (but I am using your fork of SerializedDictionaries) and tested this. I got the following
Changing return getDrawerMethod.Invoke(
type,
new object[] { type, new Type[0], isPropertyManagedReferenceType }
) != null; Has prevented any further errors. |
Interesting! What version of Unity are you on? Same as @maarten-abbey? |
I'm on version 6000.0.23f1 and having this problem. Your previous fix was working fine for me on 2023.3.40f1, and I upgraded to Unity 6 the other day and the bug came back, so I assume it's from the same cause as OP |
I select a database asset, such as the provided
TMPEffects/Resources/Databases/ShowAnimationDatabase.asset
. The inspector shows nothing, and an error message is posted to the console.The issue is in the line
return getDrawerMethod.Invoke(type, new object[] { type }) != null;
inSCEditorUtility.cs
. For me, this is within the#if UNITY_2022_3_OR_NEWER
brackets.I've added a
try
around this line, returning afalse
in the catch, and that solves the issue for me.I have a clean installation of TMPEffects set up from just a few days ago.
I use the next upcoming version of Unity, version 2023.3.0b10. I believe this version branch will at some point be part of "Unity 6".
The text was updated successfully, but these errors were encountered: