update to .net 8 #10
Merged
update to .net 8 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanukiSharp
reviewed
Jun 26, 2024
| @@ -13,7 +13,7 @@ | |||
| <Authors>rducom</Authors> | |||
| <Description>SqlBackupsTools</Description> | |||
| <PackageProjectUrl>https://github.com/LuccaSA/SqlBackupTools</PackageProjectUrl> | |||
| <Copyright>Copyright Lucca 2021</Copyright> | |||
| <Copyright>Copyright Lucca 2024</Copyright> | |||
There was a problem hiding this comment.
Tu peux mettre <Copyright>Copyright Lucca $([System.DateTime]::Now.Year)</Copyright> pour ne plus jamais être emmerdé, sauf si tu veux le faire à la main pour une bonne raison.
TanukiSharp
reviewed
Jun 26, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "6.0.100", | |||
| "version": "v8.0.302", | |||
TanukiSharp
reviewed
Jun 26, 2024
|
|
||
| var sink = LoggerSinkConfiguration.Wrap(sink => new BackgroundWorkerSink(sink), conf => | ||
| { | ||
| var path = commandInfos.LogsPath?.Exists == true ? Path.Combine(commandInfos.LogsPath.FullName, logFileName) : "logs/" + logFileName; |
There was a problem hiding this comment.
Détail que tu ignorer:
Suggested change
| var path = commandInfos.LogsPath?.Exists == true ? Path.Combine(commandInfos.LogsPath.FullName, logFileName) : "logs/" + logFileName; | |
| var basePath = commandInfos.LogsPath?.Exists == true ? commandInfos.LogsPath.FullName : "logs"; | |
| var path = Path.Combine(basePath, logFileName); |
kbrochet
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to .NET 8