-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakdown lost some addressess? #326
Comments
Hmmmm that is really strange, I think something changed because on all the recent commits addresses are getting deleted. I have paused the run but will need to investigate to find the root cause. |
Not sure if @lyricnz has any idea but there haven't been any major changes on our end so looks like something might have changed on the NBN side? |
Yeah, and if you plug that address into NBN, it acknowledges the address, but says more work needs to be done for this site to be connected. All the ones I had a look at, all looked like sensible removals to me, as they don't have any active NBN connections to them. |
Looking through the records while a lot of the addresses getting removed are ones without a valid LocID, some do have valid IDs. |
The script should be using the listed locID in the results file and just querying NBN for updated details. NBN has updated their autocomplete API to be less generous with matching it seems but I'm not sure why we are seemingly redoing this search... |
Ok this is interesting it's a 404 error: https://github.com/LukePrior/nbn-upgrade-map/actions/runs/7946125610/job/21693534967 |
I think it has to do with |
I don't know if it's blocking us or something else because it works on reqbin, but not locally https://places.nbnco.net.au/places/v2/details/ChIJba6w8Tik12oRtX2Iuq5D51k
Can anyone confirm if this is same for them. |
Not sure how you want me to test, but link doesn't work, and that line, gives me error in powershell. That LOCID does work on the script I used to run myself. timestamp : 1709024991023 |
I've set it to rerun, seems the failing addresses have been fully removed from NBN so I guess not too much of an issue. I think when the suburbs get updated again it will try to add them back with their new locID if available. https://github.com/LukePrior/nbn-upgrade-map/actions/runs/8062401331/job/22022041834 |
Will revisit in a few weeks but hopefully it should stabilise, once it does can look into adjusting stats |
Surely, there aren't just addresses that aren't there anymore? This doesn't look quite right.
The text was updated successfully, but these errors were encountered: