Merge pull request #551 from LumpBloom7/HoldNote-excess-input-passthr…

…ough

Prevent HOLD notes from blocking input meant for future hitobjects

osu.Game.Rulesets.Sentakki/Objects/Drawables/DrawableHold.cs

@@ -71,6 +71,7 @@ protected override void OnFree()
             base.OnFree();
             HoldStartTime = null;
             TotalHoldTime = 0;
+            pressedCount = 0;
         }
 
         protected override void UpdateInitialTransforms()
@@ -199,6 +200,9 @@ protected override void ClearNestedHitObjects()
 
         private bool beginHoldAt(double timeOffset)
         {
+            if (HoldStartTime is not null)
+                return false;
+
             if (timeOffset < -Head.HitObject.HitWindows.WindowFor(HitResult.Miss))
                 return false;
 
@@ -214,6 +218,8 @@ private void endHold()
             HoldStartTime = null;
         }
 
+        // Tracks how many inputs are pressing on this HitObject currently
+        private int pressedCount = 0;
         public bool OnPressed(KeyBindingPressEvent<SentakkiAction> e)
         {
             if (AllJudged)
@@ -222,13 +228,17 @@ public bool OnPressed(KeyBindingPressEvent<SentakkiAction> e)
             if (e.Action != SentakkiAction.Key1 + HitObject.Lane)
                 return false;
 
+            pressedCount++;
+
             if (beginHoldAt(Time.Current - Head.HitObject.StartTime))
             {
                 Head.UpdateResult();
                 NoteBody.FadeColour(AccentColour.Value, 50);
+                return true;
             }
 
-            return true;
+            // Passthrough excess inputs to later hitobjects in the same lane
+            return false;
         }
 
         public void OnReleased(KeyBindingReleaseEvent<SentakkiAction> e)
@@ -239,7 +249,9 @@ public void OnReleased(KeyBindingReleaseEvent<SentakkiAction> e)
             if (e.Action != SentakkiAction.Key1 + HitObject.Lane)
                 return;
 
-            endHold();
+            // We only release the hold once ALL inputs are released
+            if (--pressedCount == 0)
+                endHold();
 
             if (!AllJudged)
                 NoteBody.FadeColour(Color4.Gray, 100);