Merge pull request #499 from LumpBloom7/Extended-mod-info

Add extended mod info
LumpBloom7 · Oct 8, 2023 · 9851526 · 9851526
2 parents 9fe65b0 + b50418d
commit 9851526
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/osu.Game.Rulesets.Sentakki/Mods/SentakkiModChallenge.cs b/osu.Game.Rulesets.Sentakki/Mods/SentakkiModChallenge.cs
@@ -23,6 +23,8 @@ public class SentakkiModChallenge : ModFailCondition, IApplicableToDrawableRules
         public override LocalisableString Description => SentakkiModChallengeStrings.ModDescription;
         public override string Acronym => "C";
 
+        public override string ExtendedIconInformation => $"{(int)LiveSetting.Value}♥";
+
         public override IconUsage? Icon => FontAwesome.Solid.HeartBroken;
         public override ModType Type => ModType.DifficultyIncrease;
 

diff --git a/osu.Game.Rulesets.Sentakki/Mods/SentakkiModHardRock.cs b/osu.Game.Rulesets.Sentakki/Mods/SentakkiModHardRock.cs
@@ -14,17 +14,19 @@ public class SentakkiModHardRock : ModHardRock, IApplicableToHitObject
     {
         public override double ScoreMultiplier => 1;
 
+        public override string ExtendedIconInformation => $"{(JudgementMode.Value == SentakkiJudgementMode.Normal ? string.Empty : JudgementMode.Value)}";
+
         public override void ApplyToDifficulty(BeatmapDifficulty difficulty)
         {
             // This is a no-op since we don't use beatmap difficulty
             // The only reason we still inherit from ModHardRock is to be able to use their localized strings
         }
 
         [SettingSource(typeof(SentakkiModHardRockStrings), nameof(SentakkiModHardRockStrings.JudgementMode), nameof(SentakkiModHardRockStrings.JudgementModeDescription))]
-        public Bindable<SentakkiJudgementMode> judgementMode { get; } = new Bindable<SentakkiJudgementMode>(SentakkiJudgementMode.Maji);
+        public Bindable<SentakkiJudgementMode> JudgementMode { get; } = new Bindable<SentakkiJudgementMode>(SentakkiJudgementMode.Maji);
 
         [SettingSource(typeof(SentakkiModHardRockStrings), nameof(SentakkiModHardRockStrings.MinimumResult), nameof(SentakkiModHardRockStrings.MinimumResultDescription))]
-        public Bindable<SentakkiHitResult> minimumValidResult { get; } = new Bindable<SentakkiHitResult>(SentakkiHitResult.Good);
+        public Bindable<SentakkiHitResult> MinimumValidResult { get; } = new Bindable<SentakkiHitResult>(SentakkiHitResult.Good);
 
         public void ApplyToHitObject(HitObject hitObject)
         {
@@ -35,8 +37,8 @@ public void ApplyToHitObject(HitObject hitObject)
             if (hitObject.HitWindows is not SentakkiHitWindows shw)
                 return;
 
-            shw.MinimumHitResult = (HitResult)minimumValidResult.Value;
-            shw.JudgementMode = judgementMode.Value;
+            shw.MinimumHitResult = (HitResult)MinimumValidResult.Value;
+            shw.JudgementMode = JudgementMode.Value;
         }
 
         public enum SentakkiHitResult