Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Hold release checks #568

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Improve Hold release checks #568

merged 2 commits into from
Apr 12, 2024

Conversation

LumpBloom7
Copy link
Owner

Holds will no longer release as long as the lane is pressed by something. This prevents the situation where the hold is released by an input that was pressed prior to the hold note existing.

Example scenario:

  1. Finger one on lane 1
  2. Hold note spawns
  3. Finger two on lane 1, hold is pressed
  4. Finger one off lane 1, hold is released despite finger two still being there

@LumpBloom7 LumpBloom7 added the tweak A minor change to an existing feature label Mar 24, 2024
@LumpBloom7 LumpBloom7 merged commit 21b1808 into master Apr 12, 2024
3 checks passed
@LumpBloom7 LumpBloom7 deleted the Hold-input-checks branch April 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tweak A minor change to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant