Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceMonitor Configuration #226

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

vquie
Copy link
Contributor

@vquie vquie commented May 24, 2024

Summary

  • Added: servicemonitor.yaml template for ServiceMonitor resource.
  • Modified: deployment.yaml to include YAML front matter.
  • Updated: values.yaml to include ServiceMonitor configuration options.

Details

  • deployment.yaml:

    • Added YAML front matter (---) to the beginning of the file for proper YAML formatting.
  • values.yaml:

    • Introduced a new serviceMonitor section with the following default values:
      • enabled: false
      • interval: 60s
      • scrapeTimeout: 20s
  • servicemonitor.yaml:

    • New file created to define the ServiceMonitor resource for Prometheus monitoring.

These changes aim to enhance the monitoring capabilities of our deployments by optionally enabling ServiceMonitor configurations.

Testing

  • Ensure that the deployment works as expected without enabling the ServiceMonitor.
  • Test enabling the ServiceMonitor and verify that it integrates correctly with Prometheus.

Please review the changes and provide feedback or approval for merging.

- Introduced `servicemonitor.yaml` for Prometheus monitoring.
- Added `serviceMonitor` configuration in `values.yaml`.
- Prefixed `deployment.yaml` with YAML document separator.
@till till merged commit f1d4912 into Luzilla:main May 24, 2024
9 of 10 checks passed
@till
Copy link
Contributor

till commented May 24, 2024

Thanks very much @vquie

@vquie vquie mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants