Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bump_version #28

Open
luisaforozco opened this issue Mar 28, 2024 · 6 comments
Open

Add bump_version #28

luisaforozco opened this issue Mar 28, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@luisaforozco
Copy link
Collaborator

luisaforozco commented Mar 28, 2024

Let's use bump_my_version and setup the CI/CD to automate the bumping of the version every time we make a release.
Right now in setup.py there is:

version='{{VERSION_PLACEHOLDER}}',

That is gotten from the action pypi_release.yaml as steps.tag.outputs.TAG_NAME.

@SCiarella
Copy link
Collaborator

bump-my-version fails when called in the github action, see for example here.
However, I can execute it locally, so I do not understand this problem.

@luisaforozco
Copy link
Collaborator Author

The reason for using python 3.11.1 instead of python 3.11 is because of other dependencies like lie_learn?

@SCiarella
Copy link
Collaborator

The bump action has been fixed.
Still, the publication does not work due to the outdated version of lie_learn on pypi.

@luisaforozco
Copy link
Collaborator Author

What about using python 3.10 for the publish action?

@SCiarella
Copy link
Collaborator

SCiarella commented Apr 5, 2024

The problem is this

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: lie-learn@                               
         git+https://github.com/AMLab-Amsterdam/lie_learn. See                  
         https://packaging.python.org/specifications/core-metadata for more     
         information.  

which is caused by requiring lie-learn@ git+https://github.com/AMLab-Amsterdam/lie_learn (pypi does not like git versions).
If I simply require the pypi version lie_learn, then speckcn2 could be uploaded on pypi, but it would not build.

@SCiarella SCiarella added the bug Something isn't working label Apr 5, 2024
@SCiarella SCiarella self-assigned this Jun 3, 2024
@v1kko v1kko self-assigned this Jun 3, 2024
@v1kko
Copy link
Collaborator

v1kko commented Jun 26, 2024

the dependency problem is fixed in #35

@v1kko v1kko removed their assignment Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants