Update packaging & smaller fixes #12
Conversation
Codecov Report
Additional details and impacted files |
|
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
| @@ -10,13 +10,10 @@ | |||
|
|
|||
| due.cite(Doi("10.1371/journal.pcbi.1004568"), | |||
There was a problem hiding this comment.
We're importing duecredit directly from upstream mdanalysis - do we care about this? I don't actually know if it matters and/or if it might be better not to do this. The alternative is just to add the vendored file here (it's a reasonably cost-free process).
There was a problem hiding this comment.
One still needs to install duecredit IIRC and I'd assume that people would install it together with MDA if they cared about it. So I think it's ok to leave it imported from MDA.
At the end of the day, this package does not run without MDA so we can use it from there.
| @@ -10,13 +10,10 @@ | |||
|
|
|||
| due.cite(Doi("10.1371/journal.pcbi.1004568"), | |||
There was a problem hiding this comment.
One still needs to install duecredit IIRC and I'd assume that people would install it together with MDA if they cared about it. So I think it's ok to leave it imported from MDA.
At the end of the day, this package does not run without MDA so we can use it from there.
| classifiers = [ | ||
| "Development Status :: 6 - Mature", | ||
| "Environment :: Console", | ||
| "Intended Audience :: Science/Research", | ||
| "License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)", | ||
| "Programming Language :: C", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Topic :: Scientific/Engineering", | ||
| "Topic :: Software Development :: Libraries :: Python Modules", | ||
| ] |
There was a problem hiding this comment.
oops... these metadata were missing? Thanks for adding!
|
thank you! |
Fixes #11
Changes made in this Pull Request:
PR Checklist