Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda install instructions #14

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Add conda install instructions #14

merged 5 commits into from
Jan 2, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 29, 2023

Fixes #13

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Merging #14 (37d5cd6) into main (941dbb1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay IAlibay marked this pull request as ready for review December 29, 2023 02:25
@IAlibay
Copy link
Member Author

IAlibay commented Dec 29, 2023

Will need #12 merged before CI can be green here.

@@ -38,6 +38,19 @@ for `pip`.

Ensure that you have [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/index.html) installed.

##### From conda-forge

You can install [pathsimanalysis from the conda-forge channel](https://anaconda.org/conda-forge/pathsimanalysis) with
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry for the double post - looks like the previous one got added to a commit instead of the PR.

My question was whether this might conflict with the "from source" comment above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I guess, but the pip installation (which may use wheels) was already misleading. I just changed it into package/source.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs update. I added conda instructions to the README. I am approving but wait for CI.

split in package and source installation
@orbeckst orbeckst merged commit 9c3ec0f into main Jan 2, 2024
30 checks passed
@orbeckst orbeckst deleted the conda-docs branch January 2, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document conda installation path in docs
2 participants