-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snapthots and add release notes for MDAnalysis 2.8.0 #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the release and CI working -- but I'm slightly confused about the snapshot tests if they are what I think they are, i.e. testing what can be read from a format... I think the original way of generating the TopologyAttr tables from the MDAnalysis tests worked well for the original paradigm, but perhaps not so well for the new guessers structure.
Thanks so much for doing this @RMeli! |
THB, I haven't looked closely at what the tests do, and I was just following the release instructions. I think the User Guide needs to be updated anyways for the changes of the new guessers? |
Sorry not looked at the contents of this PR yet, but just wanted to chime in and say that, in my opinion, I think the user guide will need updating for the new guesser framework before a release is made. We've already had folks ask about how they should use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just merge this and worry about more docs later?
Regarding guessers: there's PR #213 |
Fine by me, but I think we will need to have the guesser documentation done before a |
I wouldn't hold up this PR for something that can be added later independently. Of course it would be great to have guessers in here but that's not realistically happening in the next month or two, or does anyone think differently? |
I am going to merge this PR so that other PRs won't fail because of the snapshot/guessers issue. |
📚 Documentation preview 📚: https://mdanalysisuserguide--398.org.readthedocs.build/en/398/